Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrating cross_seg_comparison into seg_compare script #3

Merged
merged 12 commits into from
Dec 5, 2024
Merged

Conversation

egelfan2
Copy link
Collaborator

  • remove cross_seg_comparison standalone script
  • integrated cross_seg_comparison functionality with seg_compare script
  • updated seg_compare user guide to show functionality (sankey diagram doesn't load in github browser but functions)

@egelfan2 egelfan2 requested a review from berl October 11, 2024 18:34
@berl
Copy link
Collaborator

berl commented Oct 15, 2024

@egelfan2 can you fix the merge conflicts? maybe you made your initial branch a while back?

@egelfan2
Copy link
Collaborator Author

Updated to remove merge conflicts

Copy link
Collaborator

@berl berl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add the requirement(s), make sure things work with a fresh pip install. I also added issue #5, which would have caught this. we can merge this once the requirements are in and then add testing in another PR.

@@ -6,15 +6,16 @@
import scanpy as sc
import seaborn as sns
from scipy import sparse
from scipy.spatial import cKDTree
from pathlib import Path
import plotly.graph_objs as go
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to add plotly as a requirement

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added plotly (and requisite dependency kaleido for saving png images) and tested fresh install

@berl
Copy link
Collaborator

berl commented Dec 3, 2024

also, the notebook doesn't have a visual of the sankey diagram:
image

the notebook is serving as a how-to and also as way for people to see how it looks without running anything, so we need to make sure it's intact. could even save out a .png when it runs and load it back in.

@egelfan2
Copy link
Collaborator Author

egelfan2 commented Dec 3, 2024

the notebook is serving as a how-to and also as way for people to see how it looks without running anything, so we need to make sure it's intact. could even save out a .png when it runs and load it back in.

I'll try the png loading option, unfortunately the direct loading doesn't seem to work with jupyter.

Copy link
Collaborator

@berl berl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@berl berl merged commit 79e81ee into main Dec 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants